Skip to content

Add BeanPostProcessors in bulk #24756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

stsypanov
Copy link
Contributor

In one of my applications there's about 50 post processors added in loop to CopyOnWriteArrayList. I think this can be improved by using bulk method where lock/unlock happens only once for all PP and less garbage is produced inside of CopyOnWriteArrayList.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 21, 2020
@jhoeller jhoeller self-assigned this May 13, 2020
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 13, 2020
@jhoeller jhoeller added this to the 5.3 M1 milestone May 13, 2020
@jhoeller
Copy link
Contributor

I'll cover this as part of a larger revision which also covers #24681. Note that I opted for keeping the public surface limited as-is, only exposing addBeanPostProcessors on AbstractBeanFactory and checking for it in PostProcessorRegistrationDelegate (which we do there for other purposes already).

@jhoeller jhoeller closed this in a3c5625 May 13, 2020
@stsypanov stsypanov deleted the bf branch May 13, 2020 14:09
kenny5he pushed a commit to kenny5he/spring-framework that referenced this pull request Jun 21, 2020
Also includes bulk addition in PostProcessorRegistrationDelegate.

Closes spring-projectsgh-24681
Closes spring-projectsgh-24756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants