Skip to content

Handle null as null in Yaml #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Handle null as null in Yaml #1798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spring-beans/src/main/java/org/springframework/beans/factory/config/YamlProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ else if (value instanceof Collection) {
}
}
else {
result.put(key, (value != null ? value : ""));
result.put(key, value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a too simplistic view of the problem I am afraid. Properties does not support null value (per javadoc).

}
});
}
Expand Down
12 changes: 12 additions & 0 deletions spring-beans/src/test/java/org/springframework/beans/factory/config/YamlProcessorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,16 @@ public void process(Properties properties, Map<String, Object> map) {
});
}

@Test
public void nullValue() {
this.processor.setResources(new ByteArrayResource("foo: bar\n bar: ~".getBytes()));
this.processor.process(new MatchCallback() {
@Override
public void process(Properties properties, Map<String, Object> map) {
assertEquals(null, properties.get("bar"));
assertEquals(1, properties.size());
}
});
}

}