Skip to content

The link of Server-Sent Events is broken #34704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
acktsap opened this issue Apr 2, 2025 · 1 comment
Closed

The link of Server-Sent Events is broken #34704

acktsap opened this issue Apr 2, 2025 · 1 comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: documentation A documentation task

Comments

@acktsap
Copy link
Contributor

acktsap commented Apr 2, 2025

The link of Server-Sent Events is broken.

spring-framework/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/SseEmitter.java

Line 38 in dd888ed

* <a href="https://www.w3.org/TR/eventsource/">Server-Sent Events</a>.

Actually it's not exactly broken. It goes to https://html.spec.whatwg.org/multipage/. But i think it should go to https://html.spec.whatwg.org/multipage/server-sent-events.html
acktsap added a commit to acktsap/spring-framework that referenced this issue Apr 2, 2025
@acktsap
Fix broken link for Server-Sent Events
d1b609a 
Closes spring-projectsgh-34704

Signed-off-by: Taeik Lim <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 2, 2025
@acktsap acktsap mentioned this issue Apr 2, 2025
Closed
@sdeleuze
Copy link
Contributor

sdeleuze commented Apr 2, 2025

Please just open a PR next time.

@sdeleuze sdeleuze closed this as completed Apr 2, 2025
@sdeleuze sdeleuze added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: documentation A documentation task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken link for Server-Sent Events acktsap/spring-framework
3 participants
@sdeleuze @spring-projects-issues @acktsap