@Validated validation group not working on request body of List

[anaconda875]

Given:

@Data
@NoArgsConstructor
@AllArgsConstructor
@Builder
public class VocabularyRequest {
  @Null(groups = CollectionCreation.class)
  @NotNull(groups = VocabularyCreation.class)
  private Long collectionId;

  @Valid private List<MeaningVariantRequest> meaningVariants;
}

This @Validated works:

  @PostMapping(consumes = APPLICATION_JSON_VALUE)
  @ResponseStatus(HttpStatus.CREATED)
  @Override
  public Mono<VocabularyResponse> create(
      @Validated(VocabularyCreation.class) @RequestBody VocabularyRequest request) {
    return super.create(request);
  }

But this (applied on a List) not:

  @PostMapping(value = "/bulk", consumes = APPLICATION_JSON_VALUE)
  @ResponseStatus(HttpStatus.CREATED)
  @Validated(VocabularyCreation.class)
  public Flux<VocabularyResponse> createBatch(
      @RequestBody List<@Valid VocabularyRequest> requests) {
    return service(VocabularyService.class).createBatch(requests);
  }

Change to this, still not work:

  @PostMapping(value = "/bulk", consumes = APPLICATION_JSON_VALUE)
  @ResponseStatus(HttpStatus.CREATED)
  public Flux<VocabularyResponse> createBatch(
      @Validated(VocabularyCreation.class) @RequestBody List<VocabularyRequest> requests) {
    return service(VocabularyService.class).createBatch(requests);
  }

If changing to @RequestBody List<@Validated(VocabularyCreation.class) VocabularyRequest> requests, got compile error:

'@Validated' not applicable to type use

NOTE: By "not working", I mean validation group not working. Not sure if @Valid works or not since I didnot observe it

[anaconda875]

Hi @bclozel, any update on it?

[anaconda875]

A workarroud:

public class ValidList<E> implements List<E> {

    @Valid
    private List<E> list;

    public ValidList() {
        this.list = new ArrayList<E>();
    }

    public ValidList(List<E> list) {
        this.list = list;
    }

    // Bean-like methods, used by javax.validation but ignored by JSON parsing

    public List<E> getList() {
        return list;
    }

    public void setList(List<E> list) {
        this.list = list;
    }

    // List-like methods, used by JSON parsing but ignored by javax.validation

    @Override
    public int size() {
        return list.size();
    }

    @Override
    public boolean isEmpty() {
        return list.isEmpty();
    }

    // Other list methods ...
}

and
@Validated(VocabularyCreation.class) @RequestBody ValidList<VocabularyRequest> requests

[bclozel]

This has been discussed many times in this issue tracker, including in #32807.
If you want method validation to apply to your controller, you should annotate it (the controller class) with @Validated. See https://docs.spring.io/spring-framework/reference/web/webmvc/mvc-controller/ann-validation.html

[anaconda875]

This has been discussed many times in this issue tracker, including in #32807. If you want method validation to apply to your controller, you should annotate it (the controller class) with @Validated. See https://docs.spring.io/spring-framework/reference/web/webmvc/mvc-controller/ann-validation.html

@bclozel the issue is not about where to put @validated or @Valid on, but is about @validated not working at all. Please read my description CAREFULLY. Wherever I put the annotation on, the validation did not work. The only way to make it work is to use my workarround
Ps: your github ticket is not relevant to my issue.

[bclozel]

Please read my description CAREFULLY.

I did. I have also tried the following:

public class VocabularyRequest {

	@NotEmpty
	private String id;

	public String getId() {
		return id;
	}

	public void setId(String id) {
		this.id = id;
	}
}

@RestController
@Validated
public class TestController {

	@PostMapping(path = "/bulk", consumes = APPLICATION_JSON_VALUE)
	@ResponseStatus(HttpStatus.CREATED)
	public Flux<String> createBatch(
			@RequestBody @Valid List<VocabularyRequest> requests) {
		return Flux.fromIterable(requests).map(VocabularyRequest::getId);
	}

}

When sending [{"id":""},{"id":"2"}] as the request body, I'm getting the following in the console:

jakarta.validation.ConstraintViolationException: createBatch.requests[0].id: must not be empty
	at org.springframework.validation.beanvalidation.MethodValidationInterceptor.invoke(MethodValidationInterceptor.java:170) ~[spring-context-6.1.8.jar:6.1.8]
	Suppressed: reactor.core.publisher.FluxOnAssembly$OnAssemblyException: 
Error has been observed at the following site(s):
	*__checkpoint ⇢ HTTP POST "/bulk" [ExceptionHandlingWebHandler]

Thoughts?

[anaconda875]

@bclozel then you did not read my desc carefully.

NOTE: By "not working", I mean validation group not working. Not sure if @Valid works or not since I didnot observe it

@validated is useful only when using with validation group. Otherwise why i have to use it while i can just use @Valid?

[bclozel]

Does this comment explain better the current situation?

#31775 (comment)