@NotNull on JPA entity not respected in schema generation

[cowclaw]

Affects: spring-orm 6.1.0 / 6.1.1:

During a spring boot update (3.1.5 to 3.2), I noticed that fields in entities that are annotated as jakarta.validation.constraints.NotNull no longer lead to the correct DDL statements.

Example:

@Entity
public class TestEntity {
	@Id
	private Long id;

	@NotNull
	private String name;
}

should trigger ddl statement that contains the not null constraint for the name attribute:

create table test_entity (
    id bigint not null,
    name varchar(255) not null,
    primary key (id)
);

but it does generate the following ddl statement without the not null constraint for the name attribute:

create table test_entity (
    id bigint not null,
    name varchar(255),
    primary key (id)
);

Note that @Column(nullable = false) does still work. Only @NotNull does not.

I was able to boil it down to the spring-orm update from 6.0.13 to 6.1.0 (which happens when updating spring boot as mentioned above).

Please see the following git project where I reproduced the issue: https://github.com/cowclaw/spring-orm-problem-demo

The commits tell the whole story:

1. Show it works on spring boot 3.1.5
2. Show it is broken on spring boot 3.2.0
3. revert to spring boot 3.1.5
4. Show its broken when selectively updating spring-orm

Included is a test that fails when the DDL statement does not meet the expectations.

Thanks for the great job you do on spring framework and thanks for having a look into the issue! 😄

[bclozel]

Spring is not responsible for the generation of the schema, this is a hibernate feature.

Downgrading your sample to use ext['hibernate.version'] = "6.1.7.Final" in build.gradle and adding logging.level.org.hibernate.SQL=debug in application.properties shows the following:

2023-11-30T14:09:42.066+01:00 DEBUG 73356 --- [           main] org.hibernate.SQL                        : create table test_entity (id bigint not null, name varchar(255) not null, primary key (id))

Please reach out to the Hibernate community if you need help.

[cowclaw]

Thanks for your reply @bclozel.

I can not reproduce what you see. I created a branch combining hibernate 6.1.7.Final with spring-orm 6.1.1. It shows the same behaviour as before. The generated ddl statement lacks the not null.

2023-11-30T14:38:26.666+01:00  INFO 3040342 --- [    Test worker] org.hibernate.Version                    : HHH000412: Hibernate ORM core version 6.1.7.Final
2023-11-30T14:38:26.795+01:00  INFO 3040342 --- [    Test worker] SQL dialect                              : HHH000400: Using dialect: org.hibernate.dialect.H2Dialect
2023-11-30T14:38:27.065+01:00 DEBUG 3040342 --- [    Test worker] org.hibernate.SQL                        : 
    
    create table test_entity (
       id bigint not null,
        name varchar(255),
        primary key (id)
    )

Updating only hibernate to 6.3.1.Final and otherwise staying with the dependencies recommended by the spring boot plugin, the not null constraint is generated and the test is green as can be seen on the branch
My first guess was hibernate as well - but I was not able to show it.

[bclozel]

You should not upgrade to spring-orm 6.1.1, as this leads to an invalid combination of dependencies. Spring Boot 3.1.x depends on Spring Framework 6.0.x: your application ends of with a mix of Spring Framework 6.0.x and 6.1.x versions.

Just using Spring Boot 3.1.5 dependency management and downgrading to Hibernate 6.1.7.Final works as expected.

[cowclaw]

Spring boot 3.1.5 does work without any changes to the hibernate version suggested by the spring boot plugin.

[bclozel]

Reopening to further check for posssible regressions.

[bclozel]

@cowclaw Sorry the conversation was confusing, I mixed things up locally with dependency management overrides and the dependency locking.

@jhoeller I've found that reverting locally #30549 makes it work. Is this a regression or is there a setup problem in the first place?