CommonsClientHttpRequestFactory getHttpClient() returns HttpClient from Commons HttpClient 3.x which has been EOL'd [SPR-6719]

[spring-projects-issues]

Ryan LaMothe opened SPR-6719 and commented

I need to extend CommonsClientHttpRequestFactory and override getHttpClient() in order to use RestTemplate(ClientHttpRequestFactory requestFactory) to make authenticated restful web service calls. Unfortunately, getHttpClient() returns HttpClient from Commons HttpClient 3.x which has been end-of-life'd (EOL) and is no longer supported. The CommonsClientHttpRequestFactory and in turn RestTemplate need to use the supported HttpCore 4.x and HttpClient 4.x libraries.

---

Affects: 3.0 GA

Attachments:

• httpcomponent_wrappers.zip (4.12 kB)

Issue Links:

• Upgrade Apache HttpClient to version 4.0 [SPR-6180] #10848 Upgrade Apache HttpClient to version 4.0 ("duplicates")
• Offer a ClientHttpRequestFactory for usage with Apache HttpComponents HttpClient [SPR-7383] #12041 Offer a ClientHttpRequestFactory for usage with Apache HttpComponents HttpClient ("is duplicated by")
• CommonsClientHttpRequestFactory depends on outdated "commons-httpclient" 3.1 [SPR-7424] #12082 CommonsClientHttpRequestFactory depends on outdated "commons-httpclient" 3.1 ("is duplicated by")
• Provide a "username" and "password" properties for RestTemplate [SPR-7331] #11990 Provide a "username" and "password" properties for RestTemplate

8 votes, 10 watchers

[spring-projects-issues]

Evgeny Goldin commented

When https://jira.springframework.org/browse/SPR-7331 is resolved you won't need to do anything to specify a username and password.

[spring-projects-issues]

Bob Jacoby commented

In case someone finds it useful, I've attached a port I made of the Commons version of the ClientHttpResponse, HttpRequestFactory, and HttpResponse to work with the HttpComponent version. Has worked for me so far and configuration mirrors that of the CommonsClient.

[spring-projects-issues]

Bob Jacoby commented

Note - that in 3.0.6 the various bundled httpmessageconverters now set the content length header. This change is incompatible with httpclient 4.1 because httpclient expects this header to NOT be set. I entered an issue to at least allow the setting of the header to be configurable. See #13324