Skip to content

Replace verifyPeer with verifyMode #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Replace verifyPeer with verifyMode #2934

wants to merge 2 commits into from

Conversation

baojian123
Copy link
Contributor

@baojian123 baojian123 commented Jun 30, 2024 •
edited
Loading

Replace verifyPeer with verifyMode to select different verification mode

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Resolves: #2899

@baojian123
Replace verifyPeer with verifyMode
feab71f 
Replace verifyPeer with verifyMode to select different verification mode
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 30, 2024
@mp911de mp911de added the type: enhancement A general enhancement label Aug 8, 2024
@mp911de mp911de added this to the 3.4 M1 (2024.1.0) milestone Aug 8, 2024
mp911de pushed a commit that referenced this pull request Aug 8, 2024
@baojian123 @mp911de
Replace Lettuce's verifyPeer with verifyMode.
b41547e 
Revert modifying type of VerifyMode for DefaultLettuceClientConfiguration constructor

Closes #2899
Original pull request: #2934
mp911de added a commit that referenced this pull request Aug 8, 2024
@mp911de
Polishing.
ba2c9ba 
Remove verifyMode setters on LettuceConnectionFactory to not expose additional properties already exposed via ClientConfiguration.

Deprecate LettuceClientConfiguration.isVerifyPeer in favor of getVerifyMode.

See #2899
Original pull request: #2934
@mp911de
Copy link
Member

mp911de commented Aug 8, 2024

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Aug 8, 2024
@mp911de mp911de removed the status: waiting-for-triage An issue we've not yet triaged label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4 M1 (2024.1.0)
Development

Successfully merging this pull request may close these issues.

Support Lettuce SSL/TLS Verification Modes
3 participants
@baojian123 @mp911de @spring-projects-issues