Accept cluster nodes without hostname #1991
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedisNode can now be constructed using an empty hostname. This can happen when a node is in failover state. RedisNode exposes hasValidHost() to check whether the node has a valid hostname. Also, introduce copy constructor to avoid mutations caused by the builder.
spring-projects-issues
added
the
status: waiting-for-triage
christophstrobl
pushed a commit
that referenced
this pull request
Mar 8, 2021
RedisNode can now be constructed using an empty hostname. This can happen when a node is in failover state. RedisNode exposes hasValidHost() to check whether the node has a valid hostname. Also, introduce copy constructor to avoid mutations caused by the builder. Original Pull Request: #1991
christophstrobl
pushed a commit
that referenced
this pull request
Mar 8, 2021
Original Pull Request: #1991
christophstrobl
pushed a commit
that referenced
this pull request
Mar 8, 2021
RedisNode can now be constructed using an empty hostname. This can happen when a node is in failover state. RedisNode exposes hasValidHost() to check whether the node has a valid hostname. Also, introduce copy constructor to avoid mutations caused by the builder. Original Pull Request: #1991
christophstrobl
pushed a commit
that referenced
this pull request
Mar 8, 2021
Original Pull Request: #1991
christophstrobl
pushed a commit
that referenced
this pull request
Mar 8, 2021
RedisNode can now be constructed using an empty hostname. This can happen when a node is in failover state. RedisNode exposes hasValidHost() to check whether the node has a valid hostname. Also, introduce copy constructor to avoid mutations caused by the builder. Closes #1985 Original Pull Request: #1991
christophstrobl
pushed a commit
that referenced
this pull request
Mar 8, 2021
Original Pull Request: #1991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisNodecan now be constructed using an empty hostname. This can happen when a node is in a failover state. RedisNode exposeshasValidHost()to check whether the node has a valid hostname.Also, introduce a copy constructor to avoid mutations caused by the builder.
Closes #1985