Skip to content

Fix id conversion for fields of complex id. #4719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

christophstrobl
Copy link
Member

This PR fixes an issue where the property type for nested fields of an complex id is not handed over correctly leading to wrong conversion results eg. for Instant types that got then turned into ObjectIds.

Closes: #4707

This commit fixes an issue where the property type for nested fields of an complex id is not handed over correctly leading to wrong conversion results eg. for Instant types that got then turned into ObjectIds.
mp911de and others added 2 commits June 11, 2024 14:46
Avoid duplicate query mapping for document replacement operations when the filter query can be determined from the already mapped _id field.
@mp911de mp911de added type: regression A regression from a previous release labels Jun 12, 2024
@mp911de mp911de modified the milestone: 4.3.1 (2024.0.1) Jun 12, 2024
mp911de pushed a commit that referenced this pull request Jun 12, 2024
This commit fixes an issue where the property type for nested fields of an complex id is not handed over correctly leading to wrong conversion results eg. for Instant types that got then turned into ObjectIds.

Closes #4707
Original pull request: #4719
mp911de added a commit that referenced this pull request Jun 12, 2024
Avoid duplicate query mapping for document replacement operations when the filter query can be determined from the already mapped _id field.

See #4707
Original pull request: #4719
mp911de pushed a commit that referenced this pull request Jun 12, 2024
This commit fixes an issue where the property type for nested fields of an complex id is not handed over correctly leading to wrong conversion results eg. for Instant types that got then turned into ObjectIds.

Closes #4707
Original pull request: #4719
mp911de added a commit that referenced this pull request Jun 12, 2024
Avoid duplicate query mapping for document replacement operations when the filter query can be determined from the already mapped _id field.

See #4707
Original pull request: #4719
@mp911de
Copy link
Member

mp911de commented Jun 12, 2024

That's merged, polished, and backported now.

@mp911de mp911de closed this Jun 12, 2024
@mp911de mp911de deleted the issue/4707 branch June 12, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Id conversion handling in QueryMapper.getMappedValue(…) doesn't consider nesting
2 participants