Skip to content

Javadoc: Add @since for the new methods in Specification #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ullenboom opened this issue Jul 30, 2023 · 4 comments
Closed

Javadoc: Add @since for the new methods in Specification #3089

ullenboom opened this issue Jul 30, 2023 · 4 comments
Labels
type: documentation A documentation update type: enhancement A general enhancement
Milestone
3.0.9 (2022.0.9)

Comments

@ullenboom
Copy link

org.springframework.data.jpa.domain.Specification has some new methods since 3.0 -- addAll(...)/anyOf(...) -- the @since Javadoc tag is missing.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 30, 2023
@gregturn gregturn added type: documentation A documentation update status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 31, 2023
@gregturn
Copy link
Contributor

Pull request welcome!

@rukins rukins mentioned this issue Aug 4, 2023
Closed
@rukins
Copy link
Contributor

rukins commented Aug 4, 2023

@gregturn, It is done :)

gregturn pushed a commit that referenced this issue Aug 4, 2023
@rukins @gregturn
Add 'since' headers to Specification javadocs.
accc5c3 
See #3102, #3089
@gregturn gregturn removed the status: ideal-for-contribution An issue that a contributor can help us with label Aug 4, 2023
@gregturn gregturn added this to the 3.2 M2 (2023.1.0) milestone Aug 4, 2023
@gregturn
Copy link
Contributor

gregturn commented Aug 4, 2023 •
edited
Loading

Thanks @rukins! That's merged to main.

gregturn pushed a commit that referenced this issue Aug 4, 2023
@rukins @gregturn
Add 'since' headers to Specification javadocs.
ad61fba 
See #3102, #3089
gregturn pushed a commit that referenced this issue Aug 4, 2023
@rukins @gregturn
Add 'since' headers to Specification javadocs.
9bb406a 
See #3102, #3089
@gregturn
Copy link
Contributor

gregturn commented Aug 4, 2023

Backported to 3.1.x and 3.0.x.

@gregturn gregturn closed this as completed Aug 4, 2023
@gregturn gregturn linked a pull request Aug 4, 2023 that will close this issue
Javadoc: Add 'since' for the allOf(...), anyOf(...) methods in Specification #3102
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation A documentation update type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.9 (2022.0.9)
Development

Successfully merging a pull request may close this issue.

Javadoc: Add 'since' for the allOf(...), anyOf(...) methods in Specification
4 participants
@gregturn @ullenboom @spring-projects-issues @rukins