Skip to content

max dims of dense_vector field type should be increased #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snurf198 opened this issue May 17, 2024 · 0 comments
Closed

max dims of dense_vector field type should be increased #2911

snurf198 opened this issue May 17, 2024 · 0 comments
Labels
type: bug A general bug

Comments

@snurf198
Copy link

snurf198 commented May 17, 2024

spring-data-elasticsearch version: 5.2.5

Hi. I found a bug in the code while creating mapping for the index using indexOps.
The target file path is as below

src/main/java/org/springframework/data/elasticsearch/core/index/MappingParameters.java:173

if (type == FieldType.Dense_Vector) {
	Assert.isTrue(dims >= 1 && dims <= 2048,
			"Invalid required parameter! Dense_Vector value \"dims\" must be between 1 and 2048.");
}

When I create mapping with dense_vector field having dimension 3072, the following error occurs
Invalid required parameter! Dense_Vector value "dims" must be between 1 and 2048

Since in elasticsearch 8.11, the max value of dimension of dense_vector field has increased to 4096, the part of the code should be changed.
elastic/elasticsearch#99682

@snurf198 snurf198 changed the title increase max dims of dense_vector field type max dims of dense_vector field type should be increased May 17, 2024
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 17, 2024
@sothawo sothawo added this to the 5.4 M1 (2024.1.0) milestone May 18, 2024
@sothawo sothawo added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 18, 2024
sothawo added a commit that referenced this issue May 18, 2024
Closes #2911

(cherry picked from commit e997b39)
sothawo added a commit that referenced this issue May 18, 2024
Closes #2911

(cherry picked from commit e997b39)
(cherry picked from commit ba9edf8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants