Improve spring-boot-sample-cache UX by using Maven profiles #8202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxblum
force-pushed
the
spring-boot-sample-cache-ux-improvements
branch
from
f968bc8 to
31eac01
Compare
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: documentation
snicoll
pushed a commit
that referenced
this pull request
Feb 6, 2017
snicoll
added a commit
that referenced
this pull request
Feb 6, 2017
…ovements * pr/8202: Polish contribution Improve spring-boot-sample-cache UX by using Maven profiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-8202
The
spring-boot-sample-cacheUX improvements were part of my original PR #6967, which was to include auto-configuration support for Spring Data Geode, and by extension, Apache Geode, as a "caching provider" in Spring Boot applications using Spring's Cache Abstraction.Unfortunately, SDG/Apache Geode never made into Spring Boot's "auto-configuration" support as a "caching provider".
However, that does not mean we should not improve on the
sample cacheuser experience by leveraging Maven Profiles over resorting to "comments"!I have included the Maven Profile work I performed while working on PR #6967 (minus the SDG/Apache Geode specific changes) in this PR.