Add auto-configuration support for Spring Data Geode Repositories. #6952
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
| <artifactId>jcl-over-slf4j</artifactId> | ||
| <groupId>org.slf4j</groupId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
Can you elaborate why you removed the exclusion?
There was a problem hiding this comment.
My mistake... fixing now.
jxblum
force-pushed
the
autoconfigure-repo-data-geode
branch
2 times, most recently
from
962cb6c to
b151f7c
Compare
philwebb
added
type: enhancement
jxblum
force-pushed
the
autoconfigure-repo-data-geode
branch
from
b151f7c to
05c8022
Compare
jxblum
force-pushed
the
autoconfigure-repo-data-geode
branch
from
05c8022 to
5a4d36d
Compare
|
@snicoll, @philwebb & Spring Boot team- This PR to add auto-configuration support for Spring Data Geode If you have questions, let me know. Thanks! |
jxblum
force-pushed
the
autoconfigure-repo-data-geode
branch
from
5a4d36d to
565fbca
Compare
|
Thanks but I don't think we should consider merging this until there's a non incubating release of Geode. |
|
@philwebb - Why? What is the concern? |
|
@jxblum Primarily stability between releases. I'm assuming that whilst the project is incubating there's no commitment to compatibility with previous releases. It does appear that the graduation vote was successful so hopefully we'll get a non incubating release soon. |
philwebb
added
the
for: team-attention
|
@philwebb - Well, there are no previous releases, hence Apache Geode 1.0.0-incubating; this is the first, "official" GA release. While there were no such guarantees between "Milestone" releases (i.e. M[1-3]), which is what they have been up to this point (see here), going forward, Geode must ensure a level of compatibility between versions since GemFire 9 will be based on Apache Geode 1.0.0-incubating. Additionally, as I told @dussab, it is not like once Apache Geode graduates there is going to be a |
|
As discussed, this code is going to be delivered in a separate module outside of Spring Boot. |
philwebb
added
status: declined
This PR replaces PR #6224, which added auto-configuration support for Spring Data GemFire Repositories. However, SD GemFire depends on Pivotal GemFire, which is not Open Source (and thus NOT freely available in Maven Central) and binds the user to legal agreements that a user must accept and sign before Pivotal will allow a user to download and use Pivotal GemFire.
As such, Spring Boot cannot directly (or indirectly with Spring Data GemFire) include support for Pivotal GemFire OOTB, therefore, this PR replaces PR #6224 in order to replace Spring Data GemFire, and subsequently Pivotal GemFire, with Spring Data Geode and Apache Geode, which are both *Open Source * and are both freely available in Maven Central.
It is widely known that Apache Geode is the successor and predecessor of Pivotal GemFire. Meaning, Apache Geode is based on Pivotal GemFire 8.2.0's codebase and was released to the Apache Software Foundation (ASF) by Pivotal in April of 2015 as an incubating project. Additionally, the upcoming Pivotal GemFire 9.0 release will be rebased on Apache Geode (~1.0.0-incubating-GA) prior to release. So, in that sense, it is both a successor (first) and predecessor (second).
However, this PR SHOULD NOT BE MERGED until @philwebb and I have had a chance to discuss the future direction of Spring Boot's support for (either/both) Pivotal GemFire and Apache Geode.