[BS-162] Tune expected exceptions to support more platforms #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that some machines break when looking for ConnectionException, but not SocketException, both of which are IOExceptions. This seems to make tests pass on more machines without compromising the intentions of the API.
philwebb
added a commit
that referenced
this pull request
Jun 18, 2013
# By Greg Turnquist * BS-162: Tune expected exceptions to support more platforms
|
Merged, thanks! |
|
Just commenting here that Greg's change seems to have fixed my situation too, I can now build bootstrap and run the tests cleanly, yey. Thanks Greg! |
|
Whew! Glad to hear I wasn't the only one crashing and burning there. Privileged to help out. |
bclozel
pushed a commit
to bclozel/spring-boot
that referenced
this pull request
Jun 19, 2014
Make the link to a project's forum optional
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that some machines break when looking for ConnectionException,
but not SocketException, both of which are IOExceptions. This seems to make
tests pass on more machines without compromising the intentions of the API.