Polish #13963
Polish #13963
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
| @@ -412,8 +412,8 @@ public void process(AnnotationMetadata annotationMetadata, | |||
| DeferredImportSelector deferredImportSelector) { | |||
| Assert.state( | |||
| deferredImportSelector instanceof AutoConfigurationImportSelector, | |||
| String.format( | |||
| "AutoConfigurationImportSelector only supports %s implementations, got %s", | |||
There was a problem hiding this comment.
This isn't a typo but a conscious decision. AutoConfigurationGroup is an internal concept while the one in the exception is the public concept.
What do you think?
There was a problem hiding this comment.
@snicoll Thanks for the clarification! When I saw it, "AutoConfigurationImportSelector only supports AutoConfigurationImportSelector implementations" sounds a bit weird and it's in AutoConfigurationGroup.process(), so I was trying to change it to AutoConfigurationGroup which sounds more natural but noticed that the class is private scope as you mentioned. I wasn't sure with this change at that time but with your comment, it'd be better to be reverted for now. I'll revert it soon.
There was a problem hiding this comment.
@snicoll I reverted it and force-pushed.
There was a problem hiding this comment.
You got a valid point in any case. I'll reword that exception message
snicoll
added
the
status: waiting-for-feedback
snicoll
added
type: task
* pr/13963: Polish contribution Polish
This PR fixes some typos and polishes trivial stuff.