Skip to content

Configure oauth2client in Reactive OAuth2 client auto-configuration #18385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbhave opened this issue Sep 27, 2019 · 1 comment
Closed

Configure oauth2client in Reactive OAuth2 client auto-configuration #18385

mbhave opened this issue Sep 27, 2019 · 1 comment
Labels
type: enhancement A general enhancement
Milestone
2.2.0.RC1

Comments

@mbhave
Copy link
Contributor

mbhave commented Sep 27, 2019

This issue in Spring Security added oauth2client to the webflux configuration so that it is consistent with the servlet counterpart. Following #17949, Spring Boot explicitly configures a bean of type SecurityWebFilterChain, instead of relying on the one from Spring Security, so that ReactiveManagementWebSecurityAutoConfiguration can back off in the presence of OAuth2.

We need to update the SecurityWebFilterChain bean to include configuration for oauth2client().
@mbhave
Copy link
Contributor Author

mbhave commented Sep 27, 2019

Since the Spring Security change was made in 5.2, we should do this in 2.2.

@mbhave mbhave added the type: enhancement A general enhancement label Sep 27, 2019
@mbhave mbhave changed the title Reactive OAuth2 client configuration should be consistent with the servlet one Configure oauth2client in Reactive OAuth2 client auto-configuration Sep 27, 2019
@mbhave mbhave modified the milestones: 2.2.0.RC1, 2.2.x Sep 27, 2019
@mbhave mbhave closed this as completed in 39ed157 Sep 27, 2019
philwebb pushed a commit that referenced this issue Sep 28, 2019
@mbhave @philwebb
Configure oauth2client in Reactive OAuth2 client auto-config
8dc8ed9 
Closes gh-18385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.2.0.RC1
Development

No branches or pull requests
1 participant
@mbhave