Skip to content

Update OAuth 2.0 Issuer-based Auto Configuration #17672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue Jul 29, 2019 · 3 comments
Closed

Update OAuth 2.0 Issuer-based Auto Configuration #17672

jzheaux opened this issue Jul 29, 2019 · 3 comments
Assignees
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jul 29, 2019

Spring Security now supports deriving OAuth 2.0 configuration from multiple endpoint types.

Instead of calling:

ClientRegistrations.fromOidcIssuerLocation
// or 
JwtDecoders.fromOidcIssuerLocation
// or
ReactiveJwtDecoders.fromOidcIssuerLocation

Which only is aware of the OIDC Provider Configuration endpoint, Spring Boot could instead call:

ClientRegistrations.fromIssuerLocation
// or
JwtDecoders.fromIssuerLocation
// or
ReactiveJwtDecoders.fromIssuerLocation

which will first attempt the OIDC endpoint, and then try endpoints indicated in RFC 8414.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 29, 2019
@mbhave
Copy link
Contributor

mbhave commented Jul 29, 2019

@jzheaux Just to clarify, this would change the semantics of spring.security.oauth2.resourceserver.jwt.issuer-uri and spring.security.oauth2.client.provider.oidc-provider.issuer-uri. I don't think it should be a problem since it's done in a backward compatible way but this would mean the javadoc for these properties would need an update as well.

@mbhave mbhave added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 29, 2019
@mbhave mbhave added this to the 2.2.x milestone Jul 29, 2019
@jzheaux
Copy link
Contributor Author

jzheaux commented Jul 31, 2019

Thanks for double-checking, @mbhave. Yes, that sounds correct to me.

@mbhave
Copy link
Contributor

mbhave commented Aug 2, 2019

Closing in favor of PR #17761.

@mbhave mbhave closed this as completed Aug 2, 2019
@mbhave mbhave added the status: superseded An issue that has been superseded by another label Aug 2, 2019
@snicoll snicoll removed this from the 2.2.x milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants