Skip to content

META-INF/spring.factories: EnableAutoConfiguration should tolerate whitespace #14903

Closed
@pfoermer

Description

@pfoermer

Used Spring Boot Version: 1.5.13.RELEASE

Scenario:
Provided a custom auto configuration definition in META-INF/spring.factories of the following form:
"org.springframework.boot.autoconfigure.EnableAutoConfiguration=FQNClassA, FQNClassB".

Problem:
Spring failed to load the configuration class " FQNClassB", because no whitespace trimming was done.

Proposed improvement:
As a java identifier can not have got any whitespace in it, whitespace trimming should be applied for a class token in EnableAutoConfiguration key.
In my opinion this would make a definition more robust, as whitespace mistakes are harder to review and this might be an unexpected behaviour from user perspective as whitespace is expected to be ignored.

Metadata

Metadata

Assignees

No one assigned

    Labels

    for: external-projectFor an external project and not something we can fixstatus: invalidAn issue that we don't feel is valid

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions