[BATCH-2760] Failed JobExecution due to unavailable TaskExecutor leaves End Time unpopulated #643
Conversation
…es End Time unpopulated On instances when the taskExecutor is not picking up the submitted Job Execution, with this fix we are explicitly setting the End Time of the JobExecution in order not to give false positives via the JobExplorer#findRunningJobExecutions(). This last method is judging on running Job Executions based on End Time being null.
[BATCH-2760] Failed JobExecution due to unavailable TaskExecutor leaves End Time unpopulated
|
I've used |
|
Jira ticket: https://jira.spring.io/browse/BATCH-2760 |
…es End Time unpopulated also adding setting the Start Time otherwise it's unpopulated as well. The Last Updated is getting set within the update() explicitly.
taskExecutor#execute() error
|
I've added:
|
|
This PR implies that the job ran when in fact it didn't. Personally, I'd rather see us fix the logic in the places where we evaluate if a job is running to exclude those that haven't started in the first place. We can continue the discussion for this in the Jira issue BATCH-2675. I'm going to close this now until we determine a best course. We can always re-open it if we agree that this is the right path. |
|
@mminella Thanks for the review. I'm continuing the discussion in BATCH-2675 with an alternative approach. thanks! |
|
As a continuation of the above discussion in the comment section of: https://jira.spring.io/browse/BATCH-2675, I've raised a new PR: #659 |
On instances when the
taskExecutoris not picking up the submitted Job Execution, with this fix we are explicitly setting the End Time of the JobExecution in order not to give false positives via theJobExplorer#findRunningJobExecutions(). This last method is judging on running Job Executions based on End Time being null.