Add remote chunking sample #603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
force-pushed
the
remote-chunking-sample
branch
2 times, most recently
from
dfe13ea to
d559a92
Compare
mminella
reviewed
May 16, 2018
| */ | ||
|
|
||
| @Bean | ||
| public ItemWriter<Integer> itemWriter() { |
There was a problem hiding this comment.
This should, at a minimum, return ItemStreamWriter since the ChunkMessageChannelItemWriter does implement ItemStream. That being said, for components like this, I actually usually recommend returning the concrete type so that Spring can see all interfaces implemented.
| /* | ||
| * Configure inbound flow (requests coming from the master) | ||
| */ | ||
|
|
| /* | ||
| * Configure outbound flow (replies going to the master) | ||
| */ | ||
|
|
fmbenhassine
force-pushed
the
remote-chunking-sample
branch
from
d559a92 to
1ed5fa3
Compare
|
Hi Michael, Thank you for the review. I removed the extra spaces and made Kr, |
|
This PR leaves a |
This commit adds a self contained remote chunking sample that uses an embedded JMS broker (for simplicity). Even though the broker is embedded, communication between the master and workers is still done through JMS queues and Spring Integration channels and messages are sent over the wire through a TCP port. This commit also fixes a few typos in the documentation section about remote chunking. Resolves BATCH-2721
fmbenhassine
force-pushed
the
remote-chunking-sample
branch
from
1ed5fa3 to
8aad392
Compare
|
Rebased and merged as 026bbe0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves BATCH-2721. It adds a self contained remote chunking sample that uses an embedded JMS broker (for simplicity). Even though the broker is embedded, communication between the master and workers is still done through JMS queues and Spring Integration channels and messages are sent over the wire through a TCP port.
The sample in this PR will not only enrich the current collection of samples, but also serve as a basis to show the added value of the feature we are trying to implement in BATCH-2686.
This PR also fixes a few typos in the documentation section about remote chunking.