Skip to content

Upgrade to Gradle 7 #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
excolo-rick opened this issue Jan 7, 2022 · 3 comments · Fixed by #674
Closed

Upgrade to Gradle 7 #572

excolo-rick opened this issue Jan 7, 2022 · 3 comments · Fixed by #674
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@excolo-rick
Copy link

excolo-rick commented Jan 7, 2022

Describe the bug
Project and samples are not buildable in Java 17 due to Gradle 7 requirement and deprecation/removal of compile dependency syntax.

To Reproduce
Open project in environment running J17, and update gradle-wrapper.properties to a J17-supported version, e.g 7.3.2

Expected behavior
The project to be usable in an up-to-date environment.

Cause
The compile instruction was deprecated in Gradle 6, per https://docs.gradle.org/current/userguide/upgrading_version_5.html

It was removed from Gradle 7, and 7.3 is required for Java 17.

Solution
Change all compile instructions in gradle dependancy lists to implementation (and all testCompile to testImplementation). There are a few other changes per the upgrade instructions, but I didn't see instances of them in the checked files. This change will not adverssely impact earlier-version users as it's to bring in line with Gradle 6 deprecation.

@excolo-rick excolo-rick added the type: bug A general bug label Jan 7, 2022
@jgrandja
Copy link
Collaborator

Thanks for the request @think-info.

FYI, this project depends on Spring Security 5.5, which compiles against JDK 1.8.

We do plan on upgrading to Gradle 7 soon.

@jgrandja jgrandja added type: enhancement A general enhancement and removed type: bug A general bug labels Jan 10, 2022
@jgrandja jgrandja self-assigned this Jan 10, 2022
@VonUniGE
Copy link

VonUniGE commented Mar 12, 2022

Upgrading to Gradle 7 is not yet possible because of the spring-build-conventions dependency. The development of this plugin seems to have stopped. Last commit is dated from 29 June 2021.

Should this plugin still be used ?

See also this issue: spring-gradle-plugins/spring-build-conventions#95

@jgrandja jgrandja changed the title Update Gradle dependencies syntax for deprecation Upgrade to Gradle 7 Mar 25, 2022
@jgrandja jgrandja assigned sjohnr and unassigned jgrandja Mar 25, 2022
@jgrandja jgrandja added this to the 0.3.0 milestone Mar 25, 2022
@jgrandja
Copy link
Collaborator

@VonUniGE We have a few changes that need to be made, including spring-build-conventions, before we can upgrade to Gradle 7. I've scheduled this for next release.

sjohnr pushed a commit to sjohnr/spring-authorization-server that referenced this issue Mar 31, 2022
sjohnr pushed a commit to sjohnr/spring-authorization-server that referenced this issue Mar 31, 2022
sjohnr pushed a commit to sjohnr/spring-authorization-server that referenced this issue Apr 1, 2022
sjohnr pushed a commit to sjohnr/spring-authorization-server that referenced this issue Apr 4, 2022
sjohnr pushed a commit to sjohnr/spring-authorization-server that referenced this issue Apr 14, 2022
sjohnr pushed a commit to sjohnr/spring-authorization-server that referenced this issue Apr 19, 2022
sjohnr pushed a commit that referenced this issue Apr 19, 2022
sjohnr pushed a commit that referenced this issue Apr 20, 2022
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants