Skip to content

Send notifications only on failure #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjohnr opened this issue Jan 15, 2025 · 0 comments
Closed

Send notifications only on failure #59

sjohnr opened this issue Jan 15, 2025 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@sjohnr
Copy link
Contributor

sjohnr commented Jan 15, 2025

Enhance the send-notification job to only trigger on a failure in a previous job.

Context:

The send-notification action sends notifications whenever it is invoked. There is a bug in GitHub Actions where the condition if: ${{ failure() }} does not work when a job in a reusable workflow fails. Further, if: ${{ !success() }} will always run if a previous job is skipped (skipped is apparently not success even though the docs say it is). This means we can't cause the notification only to be sent on failure.

@sjohnr sjohnr added the type: enhancement A general enhancement label Jan 15, 2025
@sjohnr sjohnr self-assigned this Jan 15, 2025
@sjohnr sjohnr added this to the 1.0.4 milestone Jan 15, 2025
sjohnr added a commit to sjohnr/spring-security-release-tools that referenced this issue Jan 15, 2025
@sjohnr sjohnr closed this as completed in fdfb70a Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant