Adds reproducer for protobuf msg conversion issue (#1094) #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonzn
force-pushed
the
feature/1094-reproducer
branch
from
c54d036 to
f17e20d
Compare
Conversion of protobuf messages fails if the encoded message looks like a JSON string. Added a test that reproduces the issue.
simonzn
force-pushed
the
feature/1094-reproducer
branch
from
f17e20d to
375c5e7
Compare
|
Hasn't this already been resolved? |
Yes, it has. I don't know why this is still open, but I'm not familiar with your development process. I assumed you would add the bugfix to this PR, but it looks like you copied the reproducing test case to a new branch in be45a47 instead. So I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion of protobuf messages fails if the encoded message looks like a JSON string.
Added a test that reproduces the issue.
Reproduces #1094