Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use this lib with esp32, and got the following errors:
The problem is the compiler treats
SHTC3_ADDR_7BIT
as an int, butnumBytesRequest
is uint8_t. So it wants a version ofrequestFrom
that takes (int, uint8_t) - but there isn't one of those in esp32. There isn't one in AVR either though I haven't tried compiling on that.At any rate, seems the problem would be solved with a (uin8_t) cast, which I added. Works for me!