Skip to content

Bump query-string to v8 #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Bump query-string to v8 #2772

merged 6 commits into from
Feb 14, 2024

Conversation

RichDom2185
Copy link
Member

Description

Supersedes #2734, fixing its breaking changes.

Also updates our tsconfig.json to target ES2016 → ES2020.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

renovate bot and others added 3 commits February 12, 2024 13:50
Done because the previous version of the dependency was imported as a
namespace instead of default import.
@RichDom2185 RichDom2185 self-assigned this Feb 12, 2024
@RichDom2185 RichDom2185 marked this pull request as draft February 12, 2024 06:33
@sayomaki
Copy link
Contributor

As query-string has migrated to being a pure ESM module since v8, we have to ignore the transformation for query-string as well as all its dependencies. More info here: sindresorhus/query-string#366 (comment)

@sayomaki sayomaki marked this pull request as ready for review February 14, 2024 14:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7903078479

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.396%

Totals Coverage Status
Change from base Build 7901397061: 0.0%
Covered Lines: 5739
Relevant Lines: 14438

💛 - Coveralls

Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 1eec791 into master Feb 14, 2024
@RichDom2185 RichDom2185 deleted the bump-deps-qs branch February 14, 2024 15:06
sumomomomomo pushed a commit that referenced this pull request Feb 19, 2024
* Update dependency query-string to v8

* Fix breaking changes

Done because the previous version of the dependency was imported as a
namespace instead of default import.

* Bump target to ES2020

* Fix test errors due to ESM dependencies not being ignored

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: sayomaki <[email protected]>
linedoestrolling pushed a commit that referenced this pull request Mar 29, 2024
* Update dependency query-string to v8

* Fix breaking changes

Done because the previous version of the dependency was imported as a
namespace instead of default import.

* Bump target to ES2020

* Fix test errors due to ESM dependencies not being ignored

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: sayomaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants