add ed25519 sig-verification #355
Conversation
|
@mubarizkyc Hey this looks like the best overall submission! Thank you! Before accepting, can you follow repository conventions?
|
|
@ngundotra Pyth oracle feeds are available on Devnet and Mainnet, so the escrow work could'nt be done on localnet. However, the signature verification logic will be the same across all networks. |
| @@ -0,0 +1,21 @@ | |||
| use anchor_lang::prelude::*; | |||
| pub const ESCROW_SEED: &[u8] = b"get the best weed from us"; | |||
There was a problem hiding this comment.
nit: can we get a normal seed?
| @@ -0,0 +1,21 @@ | |||
| use anchor_lang::prelude::*; | |||
| pub const ESCROW_SEED: &[u8] = b"get the best weed from us"; | |||
| //pub const SOL_USDC_FEED: &str = "GvDMxPzN1sCj7L26YDK2HnMRXEQmQ2aemov8YBtPS7vR"; | |||
basics/solana-signature-verification/tests/solana-signature-verification.ts
Outdated
Show resolved
Hide resolved
basics/solana-signature-verification/tests/solana-signature-verification.ts
Outdated
Show resolved
Hide resolved
basics/solana-signature-verification/tests/solana-signature-verification.ts
Outdated
Show resolved
Hide resolved
basics/solana-signature-verification/tests/solana-signature-verification.ts
Outdated
Show resolved
Hide resolved
basics/solana-signature-verification/tests/solana-signature-verification.ts
Outdated
Show resolved
Hide resolved
@ngundotra sure |
|
Can you add a script to test this automatically please? |
|
@ngundotra I just ran anchor run test in my repo
|
|
Also can you please fix the CI errors? |
|
Thank you for your contributions! I'm going to help you close this out. Great work so far. Will get this cleaned up & merged in EOD |
|
@heyAyushh can you help us fix the CI? Looks like basics/counter tests are failing & this repo is failing to build, despite being valid anchor. |
|
let me get back to you soon. |
|
@mubarizkyc we are going to close this PR in favor of a simpler approach. Thank you for your contribution. You will be awarded partial bounty from Gibwork directly. They will reach out to you. |
|
@ngundotra Was it decided at the beginning of the task whether I should manage the whole CI/CD within this budget? I will be careful before wasting my time again. |
|
Sorry, the CI/CD issue was not your fault. It is normal to expect contributors to work through CI/CD issues for contributions, but this time this was not fair since CI/CD was not setup for external contribution We will fix this before issuing another bounty. Thank you @mubarizkyc |
Code for an onchain program that unlocks a vault when the token price hits a certain target after valdiating that the data send to Ed25519 program was correct via Solana sys_var instruction
.
This pull request was created for https://app.gib.work/bounties/65246598-dc39-4d3c-9928-42ae766abec8 in an attempt to solve a bounty #348 . Payment for the bounty is immediately sent to the contributor after merge.