Fix #311, removed unnecessary check for CMAKE_BUILD_TYPE #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for Release or Debug in CMAKE_BUILD_TYPE breaks some assumption in Debian packaging. Since the check is useless, it has been removed. Also fix some PUBLIC/PRIVATE mistake in target_include_directories to correctly pass the properties to client code.
jmigual
requested changes
Feb 28, 2022
Comment on lines
-7
to
-10
| set(MAJOR 1) | ||
| set(MINOR 6) | ||
| set(PATCH 0) | ||
|
|
There was a problem hiding this comment.
Do not remove these lines as, MAJOR, MINOR and PATCH are being used as a CMake property
Comment on lines
+9
to
+14
| if (NOT EXISTS ${CMAKE_SOURCE_DIR}/lib/asio/asio/README) | ||
| message("Updating submodules") | ||
| execute_process( | ||
| COMMAND git submodule update --init | ||
| WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}) | ||
| endif () |
There was a problem hiding this comment.
It is the developer responsibility to do this and not the CMake. We want to keep the CMakeLists.txt minimal if possible.
Suggested change
| if (NOT EXISTS ${CMAKE_SOURCE_DIR}/lib/asio/asio/README) | |
| message("Updating submodules") | |
| execute_process( | |
| COMMAND git submodule update --init | |
| WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}) | |
| endif () | |
| set(MAJOR 1) | |
| set(MINOR 6) | |
| set(PATCH 0) |
|
Merged as 9173946 Thanks @studiofuga |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for Release or Debug in CMAKE_BUILD_TYPE breaks some assumption in Debian packaging.
Since the check is useless, it has been removed.
Also fix some PUBLIC/PRIVATE mistake in target_include_directories to correctly pass the
properties to client code.