Migrate @aws-sdk packages to smithy-typescript #737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 5-10 mins (#3575)
Co-authored-by: AllanZhengYP <[email protected]>
* fix(shared-ini-file-loader): update ini parsing * fix(shared-ini-file-loader): use indexOf instead of split * fix(shared-ini-file-loader): require non-empty for ini parse
* chore(deps-dev): bump jest to 28.1.1 * chore(workspaces): nohoist @babel to fix missing dep @babel/traverse error * test: update unit test for jest 28 * test(lib-storage): speed up assertion of 5MB buffer
* docs(abort-controller): add message about browsers * docs(abort-controller): update packages/abort-controller/src/AbortController.ts Co-authored-by: Trivikram Kamat <[email protected]> * fix(types): global AbortController type compat --------- Co-authored-by: Trivikram Kamat <[email protected]>
* feat(codegen): add serde helper function * feat(codegen): allow non-func for filter instruction
srchase
force-pushed
the
yarn-versioning
branch
from
f641e77 to
9e9436b
Compare
pose
reviewed
Apr 18, 2023
Comment on lines
+29
to
+30
| "@smithy-io/protocol-http": "workspace:^", | ||
| "@smithy-io/types": "workspace:^", |
There was a problem hiding this comment.
Some questions:
- What's the
@smithy-ionpm namespace? Could we make sure we move all the ssdk server dependencies as well? - Do we need to add permissions and modify the MCMs to publish to it?
srchase
pushed a commit
that referenced
this pull request
Apr 26, 2023
Sometimes yarn/npm will install different version of protocol-http package under individual clients and root node_modules because of hoisting policy. Private class member will block the ts compiling Reference: microsoft/TypeScript#18499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the following packages from the AWS SDK for JavaScript v3 repository to this smithy-typescript repository.
abort-controller
chunked-blob-reader
chunked-blob-reader-native
config-resolver
credential-provider-imds
eventstream-codec
eventstream-serde-browser
eventstream-serde-config-resolver
eventstream-serde-node
eventstream-serde-universal
fetch-http-handler
hash-blob-browser
hash-node
hash-stream-node
invalid-dependency
is-array-buffer
md5-js
middleware-apply-body-checksum
middleware-content-length
middleware-endpoint
middleware-retry
middleware-serde
middleware-stack
node-config-provider
node-http-handler
property-provider
protocol-http
querystring-builder
querystring-parser
service-client-documentation-generator
service-error-classification
shared-ini-file-loader
signature-v4
smithy-client
types
url-parser
util-base64
util-body-length-browser
util-body-length-node
util-buffer-from
util-config-provider
util-defaults-mode-browser
util-defaults-mode-node
util-endpoints
util-hex-encoding
util-middleware
util-retry
util-stream-browser
util-stream-node
util-uri-escape
util-utf8
These packages are use by generic smithy-typescript generated clients and the TypeScript SSDK, and moving these packages to this repository will aide in the development of generic clients and the SSDK.
As part of migrating these packages, additional changes were made:
While the aws-sdk-js-v3 repository uses Yarn v1 with Lerna, this repository will use Yarn v3 with Turborepo. Commands can be executed from the top-level.
For instance, to test all of the client and SSDK packages, run
yarn testfrom the top level. This will assure that each package has been built before invoking itstestscript.To build a single package, run
yarn build --filter@smithy-io/protcol-http.Since these packages are consumed by aws-sdk-js-v3, it will likely be necessary to test changes to the client packages locally against with aws-sdk-js-v3. For example to test a change to
@smithy-io/protocol-http, the following can be run:@smithy-io/protocol-httppackage:cd packages/protocol-http.YARN_IGNORE_PATH=1 yarn linkcd ~/another-repo/packages/consuming-packageyarn link @smithy-io/protocol-httpOnce linked, building and testing on the consuming package can be completed per that repository.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.