backport connection poisoning to hyper 1.x client #3795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Aug 20, 2024
landonxjames
approved these changes
Aug 20, 2024
| Ok(request) => request, | ||
| Err(err) => { | ||
| return HttpConnectorFuture::ready(Err(ConnectorError::user(err.into()))); | ||
| } | ||
| }; | ||
| /*let capture_connection = capture_connection(&mut request); | ||
| let capture_connection = capture_connection(&mut request); |
There was a problem hiding this comment.
Feel like this recently uncommented out chunk could use a comment for some context. Reading the CaptureConnection docs didn't quite clear it up for me.
There was a problem hiding this comment.
This is same as the hyper 0.14 implementation. CaptureConnection allows us to capture the actual connection used for the request (once established) and query it for information or in this case poison it so it isn't used again.
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> * #3710 * #1925 * awslabs/aws-sdk-rust#977 ## Description Updates the default HTTPS client to be based off hyper 1.x, rustls, and aws-lc. See the GitHub discussion: awslabs/aws-sdk-rust#1257 This PR is a rollup of previously reviewed PRs: * Refactor the runtime structure and consolidate HTTP client implementation(s): [smithy-rs#3866](#3866) * Migrate HTTP test utils: [smithy-rs#3888](#3888) * Update runtime to use new test utils: [smithy-rs#3898](#3898) * Backport connection poisoning: [smithy-rs#3795](#3795) * Deprecate HTTP 02x presign APIs: [smithy-rs#3823](#3823) * Enable hyper1 as default client: [smithy-rs#]() * Enable hyper1 behind BMV:[smithy-rs#3973](#3973) * s2n-tls provider (by Sam): [smithy-rs#3965](#3965) * custom TLS config: [smithy-rs#4032](#4032) ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the `.changelog` directory, specifying "client," "server," or both in the `applies_to` key. - [x] For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the `.changelog` directory, specifying "aws-sdk-rust" in the `applies_to` key. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Sam Clark <[email protected]> Co-authored-by: Landon James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1925
Description
Backports connection poisoning that hyper 0.14 HTTP client has to the hyper 1.x client.
See also:
Testing
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.