add sort_categories argument #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
|
||
| .. versionadded:: 0.19.0 | ||
|
|
||
| Parameters | ||
| ---------- | ||
| to_union : list-like of Categoricals | ||
| sort_categories : boolean, default False |
There was a problem hiding this comment.
Isn't that kind of ambiguous as to whether it will sort the categories or the values in the resulting Categorical?
There was a problem hiding this comment.
I also prefer sort_categories to be explicit.
BTW, I recommend @chris-b1 to open a separate PR on pandas master for open discussion.
There was a problem hiding this comment.
Sure once you merge pandas-dev#13763, I can submit as a standalone PR
sinhrks
force-pushed
the
union_categoricals_ordered
branch
from
0971621 to
9cadc4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.