Added Tests for revise! and fixed a few errors #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing without_protected: true is no longer valid. Mongoid now relies on ForbiddenAttributesProtection for this. see: mongoid/mongoid@33bd65d
We don't need to clear persistence options. See mongoid/mongoid@af65a1b
Even if the document has not changed, revise! should create a version
|
Thanks for fixes @gautamrege! Some tests are failing now, I'll try to figure out why. 😻 |
|
There are couple of tests (un-related to my commits) that are failing on local..pushed the changes nevertheless 😈 These were the tests when not using default database. am investigating. |
|
@gautamrege I think it is related to mongoid/mongoid@0a486e0. |
|
@gautamrege any news? |
|
Heh! Got stuck with some work - looking into this now. |
Also removed the monkey patch for collection as mongoid now picks up the persistence options properly in the session. Added the with scope when we search for revisions!
|
@simi This should fix things. Let me know your thoughts. |
|
@gautamrege sorry. I missed your comment. Looks good! Awesome work @gautamrege. |
simi
added a commit
that referenced
this pull request
Oct 3, 2013
Added Tests for revise! and fixed a few errors
|
cool! |
|
I added you into contributors list. I'll give you rubygems access once I'll release this if you're interested. |
|
Awesome - I can surely help in supporting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revise! was failing and there were not test cases for it.. added them
Also a few errors fixed: