Skip to content

SG-4373 Improve documentation about local file references #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

julien-lang
Copy link
Contributor

@julien-lang julien-lang commented Jun 3, 2025

This pull request updates the documentation for handling local file fields and local storage references.

  • Add missing information regarding data structure regarding the relative_path and local_storage fields
  • Provide an additional example for submitting a path referencing a LocalStorage by name
  • Minor readability improvements

@julien-lang julien-lang requested a review from Copilot June 3, 2025 21:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation for local file link handling by refining the 'local_storage' schema and enhancing the file attachment examples.

  • Updated the 'local_storage' structure in the API reference with detailed keys.
  • Revised the attachments documentation to clarify the use of local paths vs. relative paths and improve code examples.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/reference.rst Updated the 'local_storage' schema with explicit keys and improved formatting.
docs/cookbook/attachments.rst Revised text and examples for file attachments, including minor typo fixes and code formatting improvements.
Comments suppressed due to low confidence (1)

docs/reference.rst:809

  • The inline 'TODO' comment appears to be left unintentionally. Consider removing or clarifying it.
'name': "string" | Pass,  TODO

@julien-lang julien-lang changed the title SG-4373 WIP SG-4373 Improve documentation about local file references Jun 4, 2025
@julien-lang julien-lang marked this pull request as ready for review June 5, 2025 18:25
@julien-lang julien-lang requested a review from a team June 5, 2025 18:25
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two nitpick suggestions only.

Co-authored-by: Carlos Villavicencio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants