Skip to content

Implement support for hwb() color syntax #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Conversation

devongovett
Copy link
Contributor

This implements support for the hwb() color syntax specified in the CSS Color Module Level 4 spec. HWB colors are converted to RGB during parsing, just like HSL. Tests are generated using a script based on the Web Platform Tests.

Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. It'd be great to get some more code sharing between hsl and hwb, but I can land that in a follow-up.

@emilio emilio merged commit 62d63fe into servo:master Nov 26, 2021
@emilio
Copy link
Member

emilio commented Nov 26, 2021

#293 is the follow-up. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants