Implement multi-process log file sharing on .NET Core

[derFunk]

There is a parameter shared when creating a RollingFile sink.
But currently it's throwing a NotSupportedException when set to true.
See also

serilog-sinks-rollingfile/src/Serilog.Sinks.RollingFile/Sinks/RollingFile/RollingFileSink.cs

Lines 157 to 163 in 1c88099

	#if SHARING
	_currentFile = _shared ?
	(ILogEventSink)new SharedFileSink(path, _textFormatter, _fileSizeLimitBytes, _encoding) :
	new FileSink(path, _textFormatter, _fileSizeLimitBytes, _encoding, _buffered);
	#else
	_currentFile = new FileSink(path, _textFormatter, _fileSizeLimitBytes, _encoding, _buffered);
	#endif

What's the status here?

• Is it working to write to one file from multiple processes even if this shared parameter is set to false?
• If not, will this be implemented?

[nblumhardt]

Hi @derFunk - shared works on .NET Framework, but the APIs used are not (yet?) available on .NET Core. My guess is you're receiving NotSupportedException on core - is that right? Thanks!

[derFunk]

Yes, I'm on .NET Core.
Thanks for clarification!

[nblumhardt]

Re-titled to cover the .NET Core aspect. Not sure what the appropriate cross-platform way to implement this is (close/reopen is hideously slow). Any ideas out there?

[skomis-mm]

@nblumhardt , what do you think about serializing writing/flushing with Mutexes?

[nblumhardt]

Ooh interesting - I didn't think Mutex was on .NET Core. Yes, that's the top contender then :-) 👍

[nblumhardt]

I've PR'd a basic implementation in serilog/serilog-sinks-file#27. Once we're happy with it, we can incorporate it downstream here.

[nblumhardt]

PR in #40.

[nblumhardt]

Hi all - this is now in the pre-release NuGet package, any feedback welcomed!