Add support for all UUID versions #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequelize is using Validator to validates UUID strings.
Validator supports 4 versions of UUID - 3,4,5 and all:
https://github.com/chriso/validator.js/blob/b59133b1727b6af355b403a9a97a19226cceb34b/lib/isUUID.js#L14-L19
This change is updating IsUUID to support all possible options - 3,4,5 and all.
see DefinitelyTyped/DefinitelyTyped#18777 (comment)
Other stuff
Two additional changes:
WhereOptions
-->WhereOptions<any>
as IAssociationOptionsBelongsToMany
I am not sure about any of those additional changes. I know it passed compilation and testing, but I basically choose the option that compiles.
Also running
npm run build
before making any change failed. I have upgraded to node 8 and then it passed. Is there any dependency on the node version or it was just something locally on my machine?