Skip to content

chore(release): v2.1.1 #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Conversation

lukashroch
Copy link
Collaborator

Release v2.1.1 to fix broken sequelize 6.6.5+ types

@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #1108 (7487798) into master (b60c011) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files         117      117           
  Lines        1125     1125           
  Branches      128      128           
=======================================
  Hits         1070     1070           
  Misses         23       23           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60c011...7487798. Read the comment docs.

@lukashroch
Copy link
Collaborator Author

lukashroch commented Oct 10, 2021

I did the release commit with npm run release, but had to reformat manually changelog as CI then was failing on npm run markdownlint ... though npm run release runs the npm run markdownlint as well and it did pass. Might be something to watch out for.

edit: npm run release pushing the changelog changes to the top of the file. So markdownlint then fails as there is h2 heading above the h1, might need some tweaks to release-it config

@lukashroch lukashroch merged commit ea006fc into sequelize:master Oct 10, 2021
@lukashroch lukashroch deleted the release-v2.1.1 branch October 24, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants