Skip to content

chore: Adds deploy phase that deploys to NuGet #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

chore: Adds deploy phase that deploys to NuGet #753

merged 1 commit into from
Jan 15, 2020

Conversation

Gimly
Copy link
Contributor

@Gimly Gimly commented Oct 3, 2018 •
edited
Loading

Inspired by the kubernetes-client/csharp Travis script, I created a deploy phase that uses dotnet nuget push to deploy the package directly to NuGet when the CI is run on master.

Two configuration needs to be added, NUGET_API_KEY that is the API key for NuGet and NUGET_SOURCE that contains the NuGet package name.

It is a first proposal to fix issue #752, I will update if it doesn't fit the requirement complety.

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Adds a deploy phas to the Travis CI that publishes to NuGet

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@Gimly
Adds deploy phase that deploys to NuGet
6998d3c 
Inspired by the kubernetes-client/csharp Travis script, I created a deploy phase that uses dotnet nuget push to deploy the package directly to NuGet when the CI is run on master.

Two configuration needs to be added, NUGET_API_KEY that is the API key for NuGet and NUGET_SOURCE that contains the NuGet package name.

It is a first proposal to fix issue sendgrid#752, I will update if it doesn't fit the requirement complety.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 3, 2018
@Gimly Gimly mentioned this pull request Oct 3, 2018
Closed
@thinkingserious thinkingserious added hacktoberfest difficulty: hard fix is hard in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 5, 2018
@thinkingserious
Copy link
Contributor

Hello @Gimly,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @Gimly,

Thanks again for the PR!

You have earned 9 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@thinkingserious thinkingserious changed the title Adds deploy phase that deploys to NuGet chore: Adds deploy phase that deploys to NuGet Jan 15, 2020
@thinkingserious thinkingserious self-requested a review January 15, 2020 22:41
@thinkingserious thinkingserious merged commit 02556d3 into sendgrid:master Jan 15, 2020
@thinkingserious
Copy link
Contributor

Hello @Gimly,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@Gimly Gimly deleted the patch-1 branch January 16, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gimly @thinkingserious