Skip to content

Reduced duplication in Integration tests #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2017

Conversation

dylan-asos
Copy link
Contributor

A refactor in integration tests to reduce duplication

  • Removed repetition of var host = "http://localhost:4010" from each test

  • Using fixture.host instead, similar to fixture.apiKey

No other changes - test tidy up only, no new package required.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 5, 2017
@thinkingserious thinkingserious merged commit 3585afa into sendgrid:master Sep 19, 2017
@thinkingserious
Copy link
Contributor

Hello @dylan-asos,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants