Skip to content

PSR2 fixes #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2018
Merged

PSR2 fixes #92

merged 1 commit into from
Mar 12, 2018

Conversation

valerianpereira
Copy link
Contributor

@valerianpereira valerianpereira commented Mar 10, 2018

#NAN-Fix - PSR2 standards

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 10, 2018
@SendGridDX
Copy link

SendGridDX commented Mar 10, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 10, 2018

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   80.66%   80.66%           
=======================================
  Files           3        3           
  Lines         181      181           
=======================================
  Hits          146      146           
  Misses         35       35
Impacted Files Coverage Δ
lib/Client.php 77.02% <100%> (ø) ⬆️
lib/Response.php 96.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46dcffa...4c2306b. Read the comment docs.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty labels Mar 12, 2018
@thinkingserious thinkingserious merged commit 15fa0d2 into sendgrid:master Mar 12, 2018
@thinkingserious
Copy link
Contributor

Hello @valerianpereira,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants