feat: Allows for a user to utilize self-signed certificates #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 84.7% 85.14% +0.43%
==========================================
Files 3 3
Lines 170 175 +5
==========================================
+ Hits 144 149 +5
Misses 26 26
Continue to review full report at Codecov.
|
davcpas1234
added a commit
to davcpas1234/sendgrid-php
that referenced
this pull request
Aug 18, 2018
Follow up from my PR in php-http-client (sendgrid/php-http-client#101)
4 tasks
thinkingserious
added
type: community enhancement
|
Thanks @davcpas1234! This one is our backlog for a code review. |
peter279k
reviewed
Oct 9, 2018
| * | ||
| * @return Client | ||
| */ | ||
| public function setVerifySSLCerts($verifySSLCerts) |
There was a problem hiding this comment.
It only has the setVerifySSLCerts method.
Do we need to add the getVerifySSLCerts method?
I think we have this method to get current $verifySSLCerts value.
There was a problem hiding this comment.
I think it's fine as-is. We don't have getters for the other options.
childish-sambino
removed
the
type: community enhancement
childish-sambino
changed the title
childish-sambino
approved these changes
Oct 19, 2020
childish-sambino
pushed a commit
to davcpas1234/sendgrid-php
that referenced
this pull request
Oct 19, 2020
Follow up from my PR in php-http-client (sendgrid/php-http-client#101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Feature
Supports #90
Checklist
Short description of what this PR does:
curl_init()function if, for example, the user is testing the implementation on a local server with an unknown CAIf you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.