Skip to content

Add dts "internal" validation / tests as part of CI #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Jan 5, 2023

This script is for extra typechecking of the built .d.ts files in {package_name}/dist/types/*.
Occassionally, "internal" .dts errors can result from oddities in typescript configuration,
such as: #748.

These errors would only surface for customers with skipLibCheck enabled.

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2023

⚠️ No Changeset found

Latest commit: c1308aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@silesky silesky force-pushed the test-built-internal-lib-types branch from 3d0cc2f to 8b691a9 Compare January 5, 2023 19:54
@silesky silesky requested a review from a team January 5, 2023 19:55
@silesky silesky changed the title Add dts internal validation Add dts "internal" validation / tests as part of CI Jan 5, 2023
@silesky silesky force-pushed the test-built-internal-lib-types branch 18 times, most recently from e6ca1e8 to add711f Compare January 5, 2023 23:58
@silesky silesky force-pushed the test-built-internal-lib-types branch from add711f to c1308aa Compare January 6, 2023 00:07
@silesky silesky merged commit 8f9f3bd into master Jan 6, 2023
@silesky silesky deleted the test-built-internal-lib-types branch January 6, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant