Skip to content

Add workflow to Github actions to run tests on Cassandra #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

Gor027
Copy link
Contributor

@Gor027 Gor027 commented Sep 2, 2022

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have enabled appropriate tests in .github/workflows/build.yaml in gtest_filter.

This PR adds a workflow to Github actions to run integration tests on a Cassandra cluster. There are some tests, e.g. SSL-related tests, that cannot be run on a Scylla cluster because of scylla-ccm but they can be tested on a Cassandra cluster. So, new tests that will be enabled in the Github actions, should also be added in cassandra.yml, unless the newly added features are not compatible with Cassandra.

Copy link
Collaborator

@piodul piodul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please remember to update test filters in your other PRs after this is merged.

@Gor027 Gor027 mentioned this pull request Sep 6, 2022
4 tasks
@avelanarius avelanarius merged commit b60929a into scylladb:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants