Allow clippy public API related complaints #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following name changes were introduced:
1. CassDataTypeInner::UDT -> CassDataTypeInner::Udt
- rationale: "UDT" is an acronym, and Rust style guide suggests using
CapitalizedCamelCase for acronyms.
2. UDTDataType -> Udt
- rationale1: ditto about the prefix;
- rationale2: "DataType" is redundant, as UDT is a data type by
definition.
Clippy didn't complain about previous naming, because the lint
`avoid-breaking-exported-api` was implicitly enabled. The next commit
explicitly disables it, so that Clippy will warn about such naming
issues.
The lint `avoid-breaking-exported-api` was implicitly enabled. Therefore, Clippy didn't complain about bad naming in public API. As the crate is not exposed to the public, we can disable this lint without any loss.
The tests are no longer configured in the GitHub workflows, but in the Makefile. This change updates the PR template to reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fully analogous to scylladb/scylla-rust-driver@15448c4. Pasting the commit message:
Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced.[ ] I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.[ ] I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.