Refactor CassFuture state management - more type safety and clarity
#302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the Default trait gives no benefit there. Also, this prepares for subsequent commits with the refactor.
The refactor involves employing an enum to represent the state of the future: `CassFutureExecution`. This enum has three variants: - `RunningWithoutCallback`: Indicates that the future is currently running without a callback, - `RunningWithCallback`: Indicates that the future is running with a callback, - `Completed`: Indicates that the future has completed, and it contains the result of the future. I hope this refactor makes the state transitions clearer and easier to understand, and, even more importantly, more bug-resistant.
wprzytula
force-pushed
the
refactor-cass-future
branch
from
d4851b3 to
78102ad
Compare
|
Have you looked at https://github.com/scylladb/cpp-rust-driver/pull/299/commits? Especially: 25cb370 and 665266c. Would you be able to do such refactor on top of them? TLDR, I don't want to store |
Not yet...
OK, I'll try to port it once we merge #299. |
|
The refactor got severaly outdated after #299. It requires significant changes. Moving to draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
CassFutureState, so that it is represented in a more type-safe way.Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced.[ ] I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.[ ] I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.