Skip to content

errors: make EmptyPlan return LIB_NO_HOSTS_AVAILABLE #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

muzarski
Copy link
Contributor

Cherry-picked from 22e1c29. I want to have this early for enforcing/getting coordinator tests.

As I mentioned before - this error is returned when we for some reason cannot route the request to one of the hosts. I forgot to address this earlier (there was no test case for empty plan). I'll introduce one later in this PR.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have implemented Rust unit tests for the features/changes introduced.
  • I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

As I mentioned before - this error is returned when we for some reason
cannot route the request to one of the hosts. I forgot to address this earlier
(there was no test case for empty plan). I'll introduce one later in this PR.
@muzarski muzarski added this to the 0.5 milestone May 12, 2025
@muzarski muzarski self-assigned this May 12, 2025
@muzarski muzarski requested review from Lorak-mmk and wprzytula May 12, 2025 10:47
@muzarski muzarski merged commit 2aad281 into scylladb:master May 12, 2025
12 checks passed
@muzarski muzarski deleted the empty-plan=no-hosts-available branch May 12, 2025 11:10
@wprzytula wprzytula mentioned this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants