Skip to content

CassConsistency: adjust converion to serial variants of Consistency #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

muzarski
Copy link
Contributor

According to the comment in rust-driver:

// Apparently, Consistency can be set to Serial or LocalSerial in SELECT statements 
// to make them use Paxos.

As @wprzytula noticed here: #199 (comment), this is a bug fix.

The other reason I want to have this merged quickly, is because I need it for one of the ExecutionProfile integration tests. I'll enable the test in a separate PR where I adjust some of the remaning tests from this suite.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have implemented Rust unit tests for the features/changes introduced.
  • I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

According to the comment in rust-driver:
// Apparently, Consistency can be set to Serial or LocalSerial in SELECT statements
// to make them use Paxos.
@muzarski muzarski added bug Something isn't working P0 P0 item - absolute must have labels Apr 28, 2025
@muzarski muzarski added this to the 0.5 milestone Apr 28, 2025
@muzarski muzarski self-assigned this Apr 28, 2025
@muzarski muzarski requested a review from wprzytula April 28, 2025 14:53
@muzarski muzarski merged commit 71297f9 into scylladb:master Apr 28, 2025
12 checks passed
@muzarski muzarski deleted the allow-serial-consistency-to-consistency-conversion branch April 28, 2025 15:16
@wprzytula wprzytula mentioned this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 P0 item - absolute must have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants