Skip to content

Compile integration_testing.rs conditionally #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

muzarski
Copy link
Contributor

@muzarski muzarski commented Apr 28, 2025

Fixes: #285

After the change we have:

$ cmake .. && make -j 8
...
$ objdump -TC libscylla-cpp-driver.so | grep testing_ 
<empty output>
$ cmake -DCASS_BUILD_INTEGRATION_TESTS=ON .. && make -j 8
...
$ objdump -TC libscylla-cpp-driver.so | grep testing_
00000000000eed40 g    DF .text	000000000000005e  Base        testing_cluster_get_connect_timeout
00000000000eeda0 g    DF .text	0000000000000052  Base        testing_cluster_get_port
00000000000eee00 g    DF .text	00000000000002b8  Base        testing_cluster_get_contact_points
00000000000ef0c0 g    DF .text	0000000000000026  Base        testing_free_contact_points
00000000000ef190 g    DF .text	00000000000000ee  Base        testing_statement_set_sleeping_history_listener

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have implemented Rust unit tests for the features/changes introduced.
  • [ ] I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • [ ] I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

@muzarski muzarski self-assigned this Apr 28, 2025
@muzarski muzarski changed the title Compile testing conditionally Compile integration_testing.rs conditionally Apr 28, 2025
@muzarski muzarski added this to the 0.5 milestone Apr 28, 2025
@muzarski muzarski merged commit 8d402b0 into scylladb:master Apr 28, 2025
12 checks passed
@muzarski muzarski deleted the compile-testing-conditionally branch April 28, 2025 13:26
@wprzytula wprzytula mentioned this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't compile integration_testing.rs unconditionally
2 participants