Implement local address and local port range configuration #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorak-mmk
reviewed
Apr 15, 2025
wprzytula
requested changes
Apr 16, 2025
muzarski
force-pushed
the
local_address_and_port_range
branch
from
e09a8d7 to
8a59fb6
Compare
|
v2: |
wprzytula
approved these changes
Apr 16, 2025
In addition, set the default value and implemented unit test.
Set the default value (ephemeral port range) and implemented unit test.
muzarski
force-pushed
the
local_address_and_port_range
branch
from
8a59fb6 to
0500f2e
Compare
|
v2.1: Rebased on |
5 tasks
wprzytula
approved these changes
Apr 16, 2025
Lorak-mmk
approved these changes
Apr 16, 2025
wprzytula
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #239
This pr implements
cass_cluster_set_local_addres[_n]andcass_cluster_set_local_port_range.Integration tests:
There will be a follow-up PR which enables the integration tests that we "unlocked" by implementing these. The reason is that it requires to adjust some test logic (e.g. logs filtering) and error handling. Don't want to introduce too much noise to this PR.
Pre-review checklist
[ ] I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.[ ] I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.