Skip to content

fix: prioritized tx not being cleared after skipping it #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented May 22, 2024

1. Purpose or design rationale of this PR

tests that miner can skip l2 messages if they fail CCC

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@omerfirmak omerfirmak force-pushed the omerfirmak/skip-l2-msg-test branch from a0313e7 to 1f6503d Compare May 22, 2024 12:34
@omerfirmak omerfirmak marked this pull request as draft May 22, 2024 12:45
@omerfirmak omerfirmak force-pushed the omerfirmak/skip-l2-msg-test branch 2 times, most recently from a12666a to cc8197a Compare May 22, 2024 12:48
@omerfirmak omerfirmak force-pushed the omerfirmak/skip-l2-msg-test branch from cc8197a to 3ae55bf Compare May 22, 2024 12:49
@omerfirmak omerfirmak marked this pull request as ready for review May 22, 2024 12:49
@omerfirmak omerfirmak changed the title test: add a test for skipping l2 message due to ccc error fix: prioritized tx not being cleared after skipping it May 22, 2024
0xmountaintop
0xmountaintop previously approved these changes May 23, 2024
Copy link

@0xmountaintop 0xmountaintop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omerfirmak omerfirmak requested review from Thegaram and colinlyguo May 23, 2024 10:23
Thegaram
Thegaram previously approved these changes May 23, 2024
@github-actions github-actions bot dismissed stale reviews from 0xmountaintop and Thegaram via b280998 May 23, 2024 14:00
@0xmountaintop 0xmountaintop merged commit 51bb998 into develop May 24, 2024
@0xmountaintop 0xmountaintop deleted the omerfirmak/skip-l2-msg-test branch May 24, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants