Skip to content

feat: implement relaxed period in clique #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented May 21, 2024

1. Purpose or design rationale of this PR

Block times are limiting our throughput because we can only put so many txns in a block due to circuit limits. The short term solution is to allow more frequent blocks.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@omerfirmak
Copy link
Author

depends on #735, see the second commit

@omerfirmak omerfirmak force-pushed the omerfirmak/variable-block-times branch from f8ccdca to db017ad Compare May 21, 2024 13:12
@omerfirmak omerfirmak force-pushed the omerfirmak/variable-block-times branch from 93c27c4 to a354a69 Compare May 21, 2024 14:48
Thegaram
Thegaram previously approved these changes May 22, 2024
Thegaram
Thegaram previously approved these changes May 22, 2024
colinlyguo
colinlyguo previously approved these changes May 22, 2024
@omerfirmak omerfirmak dismissed stale reviews from colinlyguo and Thegaram via c9393fa May 22, 2024 09:28
@Thegaram Thegaram merged commit dd96cec into develop May 22, 2024
7 checks passed
@Thegaram Thegaram deleted the omerfirmak/variable-block-times branch May 22, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants